Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert source to typescript, include types in package #308

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

mightyiam
Copy link
Member

No description provided.

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tsconfigs 5.0.0 None +0 12.1 kB mightyiam
eslint-config-standard-with-typescript 37.0.0 None +16 5 MB mightyiam

@socket-security
Copy link

socket-security bot commented Aug 13, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: tsconfigs@5.0.0

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@mightyiam
Copy link
Member Author

The purpose of this is to make it easier (because TypeScript) to write some more comprehensive tests. And providing the types in the package is a bonus.

I will take a closer look at this before merging. Perhaps with @rostislav-simonik .

@mightyiam
Copy link
Member Author

@SocketSecurity ignore tsconfigs@5.0.0

@mightyiam mightyiam marked this pull request as ready for review August 13, 2023 15:16
@mightyiam mightyiam merged commit 349202c into master Aug 16, 2023
13 checks passed
@mightyiam mightyiam deleted the typescript branch August 16, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

1 participant