Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow eslint-plugin-promise 6 #198

Closed
wants to merge 1 commit into from
Closed

feat: allow eslint-plugin-promise 6 #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,13 @@ on:

jobs:
ci:
strategy:
fail-fast: false
matrix:
eslint-plugin-promise:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have this in something like a compat.yml, to keep the main CI file as lean as possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra YML files here would be interpreted as malformed workflow files. Might be something for when you go for the org-wide action approach and need a repo specific override file

- 4
- 5
- 6
runs-on: 'ubuntu-latest'
steps:
- uses: 'actions/checkout@v2'
Expand All @@ -28,5 +35,8 @@ jobs:
- name: 'Install dependencies'
run: 'npm install'

- name: 'Install eslint-plugin-promise'
run: npm install -D eslint-plugin-promise@${{matrix.eslint-plugin-promise}}

- name: 'Run tests'
run: 'npm test'
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"eslint": "^7.12.1",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^4.2.1 || ^5.0.0"
"eslint-plugin-promise": "^4.2.1 || ^5.0.0 || ^6.0.0"
Copy link
Contributor Author

@nschonni nschonni Dec 22, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatly, this could just change to >=4.21, keep the testing, and update the devDep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like specifying the upper version that complies with the standard rule set, so an upgrade doesn't cause unintentional rule changes

},
"repository": {
"type": "git",
Expand Down