Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/tidwall/gjson from 1.14.1 to 1.14.2 #2654

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 8, 2022

Bumps github.com/tidwall/gjson from 1.14.1 to 1.14.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/tidwall/gjson](https://github.com/tidwall/gjson) from 1.14.1 to 1.14.2.
- [Release notes](https://github.com/tidwall/gjson/releases)
- [Commits](tidwall/gjson@v1.14.1...v1.14.2)

---
updated-dependencies:
- dependency-name: github.com/tidwall/gjson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 8, 2022
@dependabot dependabot bot requested a review from a team August 8, 2022 16:15
@roxbot
Copy link
Contributor

roxbot commented Aug 8, 2022

Images are ready for the commit at b006aa7.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.71.x-259-gb006aa721d.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/go-unit-tests b006aa7 link true /test go-unit-tests
ci/prow/go-unit-tests-release b006aa7 link true /test go-unit-tests-release

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@janisz
Copy link
Contributor

janisz commented Aug 9, 2022

looks like something is wrong with getNodesWithColumnIndex
@dhaus67

@janisz
Copy link
Contributor

janisz commented Aug 9, 2022

I think there is a regression in 1.14.2.

Following tests pasees on master (1.14.1) but fails with 1.14.2

package gjson

import (
	"testing"

	"github.com/stretchr/testify/assert"
	"github.com/tidwall/gjson"
)

func TestGetManyBytes(t *testing.T) {
	rawJson := `{"x":[{"y":[{"z":false}]}]}`
	jsonPathExpr := `{x.#.y.#.z.@boolReplace:{"true":"X","false":"-"}}`
	results := gjson.GetManyBytes([]byte(rawJson), jsonPathExpr)
	assert.Len(t, results, 1)
	actua := results[0].Raw
	expected := `{"_":[["-"]]}`
	assert.Equal(t, expected, actua)
}
# 1.14.2
Expected :{"_":[["-"]]}
Actual   :{"_":[[]]}

@janisz
Copy link
Contributor

janisz commented Aug 9, 2022

We can't update this dependency until tidwall/gjson#291

@dependabot ignore this minor version

@dependabot dependabot bot closed this Aug 9, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 9, 2022

OK, I won't notify you about version 1.14.x again, unless you re-open this PR or update to a 1.14.x release yourself.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/tidwall/gjson-1.14.2 branch August 9, 2022 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants