Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24328: Remove compliance standard logos #11201

Merged
merged 1 commit into from
May 22, 2024

Conversation

pedrottimark
Copy link
Contributor

@pedrottimark pedrottimark commented May 21, 2024

Description

cis.svg
hipaa.svg
nist.svg
pci.svg

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added

Testing Performed

Although media decreased as expected, js added size but decreased files.

  1. yarn lint in ui
  2. yarn build in ui and then compute branch - master for the following
    • wc build/static/media/*.*
      total -26396 = 908099 - 934495
    • ls -al build/static/media/*.* | wc
      files -4 = 80 - 84
    • wc build/static/js/*.js
      main.js -72 = 4635354 - 4635426
      total 7987 = 11697992 - 11690005
    • ls -al build/static/js/*.js | wc
      files -1 = 172 - 173
  3. yarn start in ui

Manual testing

  1. Visit /main/compliance/controls/PCI_DSS_3_2:1_1_2?s[groupBy]=CLUSTER&s[standard]=PCI%20DSS%203.2.1

    • with logo image before change
      compliance_controls_pci_with_image

    • without logo image after change
      compliance_controls_pci_without_image

  2. Visit /main/configmanagement/controls/CIS_Kubernetes_v1_5%3A1_1_9?s[standard]=CIS%20Kubernetes%20v1.5&s[groupBy]=CATEGORY

    • with logo image before change
      configmanagement_cpntrols_cis_with_image

    • without logo image after change
      configmanagement_cpntrols_cis_without_image

Integration testing

  • compliance/complianceDashboard.test.js
  • compliance/complianceList.test.js
  • compliance/hideScanResults.test.js

@pedrottimark pedrottimark requested a review from a team as a code owner May 21, 2024 18:55
@pedrottimark pedrottimark changed the title chore(ui): Remove compliance standard logos ROX-24328: Remove compliance standard logos May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.90%. Comparing base (3e2f098) to head (1a6b791).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11201   +/-   ##
=======================================
  Coverage   47.89%   47.90%           
=======================================
  Files        2330     2330           
  Lines      166491   166491           
=======================================
+ Hits        79748    79752    +4     
+ Misses      80414    80410    -4     
  Partials     6329     6329           
Flag Coverage Δ
go-unit-tests 47.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented May 22, 2024

@pedrottimark: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-ui-e2e-tests c045796 link false /test ocp-4-12-ui-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at c045796.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-745-gc0457960b2.

@pedrottimark
Copy link
Contributor Author

ocp-4-12-ui-e2e-tests failure

failed to fetch Cluster

@pedrottimark pedrottimark merged commit 1a5476a into master May 22, 2024
59 of 60 checks passed
@pedrottimark pedrottimark deleted the ControlDetails-svgMapping branch May 22, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants