ROX-24328: Remove compliance standard logos #11201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cis.svg
hipaa.svg
nist.svg
pci.svg
Checklist
Unit test and regression tests addedTesting Performed
Although media decreased as expected, js added size but decreased files.
yarn lint
in uiyarn build
in ui and then compute branch - master for the followingwc build/static/media/*.*
total -26396 = 908099 - 934495
ls -al build/static/media/*.* | wc
files -4 = 80 - 84
wc build/static/js/*.js
main.js -72 = 4635354 - 4635426
total 7987 = 11697992 - 11690005
ls -al build/static/js/*.js | wc
files -1 = 172 - 173
yarn start
in uiManual testing
Visit /main/compliance/controls/PCI_DSS_3_2:1_1_2?s[groupBy]=CLUSTER&s[standard]=PCI%20DSS%203.2.1
with logo image before change
without logo image after change
Visit /main/configmanagement/controls/CIS_Kubernetes_v1_5%3A1_1_9?s[standard]=CIS%20Kubernetes%20v1.5&s[groupBy]=CATEGORY
with logo image before change
without logo image after change
Integration testing