Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-23940: re-enable roxctl scan #11197

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

stehessel
Copy link
Collaborator

Description

We had disabled the roxctl scan job because of a bug in roxctl that caused the job to fail in case no vulnerabilities were found. This bug has been fixed in 4.4.2, which is now released.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@stehessel stehessel requested a review from a team May 21, 2024 15:28
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at cec8db6.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-739-gcec8db6e2e.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.90%. Comparing base (3e2f098) to head (cec8db6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11197   +/-   ##
=======================================
  Coverage   47.89%   47.90%           
=======================================
  Files        2330     2330           
  Lines      166491   166491           
=======================================
+ Hits        79748    79754    +6     
+ Misses      80414    80410    -4     
+ Partials     6329     6327    -2     
Flag Coverage Δ
go-unit-tests 47.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stehessel stehessel merged commit d985f32 into master May 22, 2024
61 checks passed
@stehessel stehessel deleted the ROX-23940/re-enable-roxctl-scan branch May 22, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants