-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-24358: compliance last scan time sortable #11193
ROX-24358: compliance last scan time sortable #11193
Conversation
Skipping CI for Draft Pull Request. |
Images are ready for the commit at 5ad4290. To use with deploy scripts, first |
6f05145
to
58e081e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11193 +/- ##
=======================================
Coverage 47.97% 47.98%
=======================================
Files 2330 2330
Lines 166730 166760 +30
=======================================
+ Hits 79990 80019 +29
- Misses 80387 80390 +3
+ Partials 6353 6351 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚢 🐳
d706f1c
to
9416f71
Compare
/retest |
Description
Added sort capability for the Last Scan Time on the
/v2/compliance/scan/stats/profiles/{profile-name}/clusters
endpoint. This required a slight modification to the query framework. See testing section from examples.Checklist
- [ ] Evaluated and added CHANGELOG entry if required- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on [openshift/openshift-docs](https://github.com/openshift/openshift-docs) and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
no-sort.json
sort.json
reverse-sort.json
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.