-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-24318: workload CVE ux polish #11181
Conversation
Skipping CI for Draft Pull Request. |
Images are ready for the commit at 9798816. To use with deploy scripts, first |
ea28f66
to
028c0ee
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11181 +/- ##
=======================================
Coverage 47.96% 47.97%
=======================================
Files 2330 2330
Lines 166706 166706
=======================================
+ Hits 79965 79970 +5
+ Misses 80388 80385 -3
+ Partials 6353 6351 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ui/apps/platform/src/Containers/Vulnerabilities/WorkloadCves/Overview/ObservedCveModeSelect.tsx
Show resolved
Hide resolved
...s/platform/src/Containers/Vulnerabilities/WorkloadCves/Overview/WorkloadCvesOverviewPage.tsx
Show resolved
Hide resolved
5ebbad4
to
eed6768
Compare
028c0ee
to
6947425
Compare
eed6768
to
b59150a
Compare
6947425
to
9798816
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11181 +/- ##
=======================================
Coverage 47.96% 47.97%
=======================================
Files 2330 2330
Lines 166706 166706
=======================================
+ Hits 79965 79970 +5
+ Misses 80388 80385 -3
+ Partials 6353 6351 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
A handful of UX fixes, mostly related to the new "With CVEs"/"Without CVEs" views, that help streamline the difference between the three Vulnerability State tabs and the ability to filter by "with cves"/"without cves".
Checklist
If any of these don't apply, please comment below.
Testing Performed
2.,3. Verify the behavior of the table title/description, and resetting of page state when navigating across vulnerability state tabs: (note that the zero results when filtering by
Deployment:wordpress
is due to not having the correct parameters sent to the autocomplete component. This needs to be fixed in a follow up.)Screen.Recording.2024-05-21.at.11.00.37.AM.mov