Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24318: workload CVE ux polish #11181

Merged
merged 3 commits into from
May 28, 2024
Merged

ROX-24318: workload CVE ux polish #11181

merged 3 commits into from
May 28, 2024

Conversation

dvail
Copy link
Contributor

@dvail dvail commented May 20, 2024

Description

A handful of UX fixes, mostly related to the new "With CVEs"/"Without CVEs" views, that help streamline the difference between the three Vulnerability State tabs and the ability to filter by "with cves"/"without cves".

  1. Removes the red "critical" color from the icon in the dropdown, opting for plain black
  2. Adjusts the header title and description above the table for all of the three vulnerability state tabs, including removing the default filters and namespace buttons from the Deferred/FP tables.
  3. Resets the filters, page, sorting, and current entity tab when switching between the three vulnerability states. With this change and the previous change, this makes the tabs feel more like independent sets of data. Prior to these changes, switching tabs looked like a minor state update, now the separation between the interactions is more clear. Fixes https://issues.redhat.com/browse/ROX-24318

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

  1. Verify that the color of the icon in the dropdown is no longer red:
    image

2.,3. Verify the behavior of the table title/description, and resetting of page state when navigating across vulnerability state tabs: (note that the zero results when filtering by Deployment:wordpress is due to not having the correct parameters sent to the autocomplete component. This needs to be fixed in a follow up.)

Screen.Recording.2024-05-21.at.11.00.37.AM.mov

Copy link

openshift-ci bot commented May 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented May 20, 2024

Images are ready for the commit at 9798816.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-788-g97988161e3.

@dvail dvail changed the base branch from master to dv/without-cves-view-e2e-tests May 21, 2024 12:21
@dvail dvail changed the title chore(ui): workload CVE ux polish ROX-24318: workload CVE ux polish May 21, 2024
@dvail dvail force-pushed the dv/workload-cve-ux-polish branch from ea28f66 to 028c0ee Compare May 21, 2024 15:00
@dvail dvail marked this pull request as ready for review May 21, 2024 15:07
@dvail dvail requested a review from a team as a code owner May 21, 2024 15:07
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (72b220c) to head (9798816).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11181   +/-   ##
=======================================
  Coverage   47.96%   47.97%           
=======================================
  Files        2330     2330           
  Lines      166706   166706           
=======================================
+ Hits        79965    79970    +5     
+ Misses      80388    80385    -3     
+ Partials     6353     6351    -2     
Flag Coverage Δ
go-unit-tests 47.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvail dvail force-pushed the dv/without-cves-view-e2e-tests branch from 5ebbad4 to eed6768 Compare May 22, 2024 16:13
@dvail dvail force-pushed the dv/workload-cve-ux-polish branch from 028c0ee to 6947425 Compare May 22, 2024 16:13
@dvail dvail force-pushed the dv/without-cves-view-e2e-tests branch from eed6768 to b59150a Compare May 22, 2024 19:26
Base automatically changed from dv/without-cves-view-e2e-tests to master May 23, 2024 17:40
@dvail dvail force-pushed the dv/workload-cve-ux-polish branch from 6947425 to 9798816 Compare May 23, 2024 18:11
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (72b220c) to head (9798816).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11181   +/-   ##
=======================================
  Coverage   47.96%   47.97%           
=======================================
  Files        2330     2330           
  Lines      166706   166706           
=======================================
+ Hits        79965    79970    +5     
+ Misses      80388    80385    -3     
+ Partials     6353     6351    -2     
Flag Coverage Δ
go-unit-tests 47.97% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvail dvail merged commit 2e9acc4 into master May 28, 2024
61 checks passed
@dvail dvail deleted the dv/workload-cve-ux-polish branch May 28, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants