Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-24096: Add profile checks sorting #11179

Merged
merged 1 commit into from
May 21, 2024

Conversation

bradr5
Copy link
Contributor

@bradr5 bradr5 commented May 20, 2024

Description

Adds sorting to the Compliance V2 Profile Checks table

Note: UX shows ability to sort by compliance statuses, however these columns are unsortable now due to our backend search framework. Will revisit these in a later release.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Manual testing, backend implementation not available. Tested by clicking on column header and checking the api call.

before:
Screenshot 2024-05-20 at 2 53 03 PM

after:
Screenshot 2024-05-20 at 2 53 12 PM

@bradr5 bradr5 requested a review from a team as a code owner May 20, 2024 19:55
@rhacs-bot
Copy link
Contributor

Images are ready for the commit at ce0056e.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-732-gce0056ea00.

Copy link
Contributor

@sachaudh sachaudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and straight forward. I like it 🚢

@bradr5 bradr5 merged commit dbce8f3 into master May 21, 2024
61 checks passed
@bradr5 bradr5 deleted the bradr/ROX-24096_profile_checks_sorting branch May 21, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants