ROX-18155: pg generic store: GetAll (#6769)

## Description A detailed explanation of the changes in your PR. Feel free to remove this section if it is overkill for your PR, and the title of your PR is sufficiently descriptive. ## Checklist - [ ] Investigated and inspected CI test results - [ ] Unit test and regression tests added - [ ] Evaluated and added CHANGELOG entry if required - [ ] Determined and documented upgrade steps - [ ] Documented user facing changes (create PR based on [openshift/openshift-docs](https://github.com/openshift/openshift-docs) and merge into [rhacs-docs](https://github.com/openshift/openshift-docs/tree/rhacs-docs)) If any of these don't apply, please comment below. ## Testing Performed TODO(replace-me) Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. Valid reasons include, for example, "CI is sufficient", "No testable changes". Feel free to attach JSON snippets, curl commands, screenshots. In addition to reviewing your code, reviewers **must** also review your testing instructions and make sure they are sufficient.
stackrox · Jul 7, 2023 · 87dd8d9 · 87dd8d9
1 parent b605d2c
commit 87dd8d9
Show file tree

Hide file tree

Showing 15 changed files with 12 additions and 171 deletions.
diff --git a/central/authprovider/datastore/internal/store/postgres/store.go b/central/authprovider/datastore/internal/store/postgres/store.go
diff --git a/central/complianceoperatorintegration/store/postgres/store.go b/central/complianceoperatorintegration/store/postgres/store.go
diff --git a/central/externalbackups/internal/store/postgres/store.go b/central/externalbackups/internal/store/postgres/store.go
diff --git a/central/group/datastore/internal/store/postgres/store.go b/central/group/datastore/internal/store/postgres/store.go
diff --git a/central/imageintegration/store/postgres/store.go b/central/imageintegration/store/postgres/store.go
diff --git a/central/logimbue/store/postgres/store.go b/central/logimbue/store/postgres/store.go
diff --git a/central/notifier/datastore/internal/store/postgres/store.go b/central/notifier/datastore/internal/store/postgres/store.go
diff --git a/central/policy/store/postgres/store.go b/central/policy/store/postgres/store.go
diff --git a/central/policycategory/store/postgres/store.go b/central/policycategory/store/postgres/store.go
diff --git a/central/policycategoryedge/store/postgres/store.go b/central/policycategoryedge/store/postgres/store.go
diff --git a/central/serviceidentities/internal/store/postgres/store.go b/central/serviceidentities/internal/store/postgres/store.go
diff --git a/pkg/search/postgres/store.go b/pkg/search/postgres/store.go
@@ -177,3 +177,15 @@ func (s *GenericStore[T, PT]) Walk(ctx context.Context, fn func(obj PT) error) e
 	}
 	return nil
 }
+
+// GetAll retrieves all objects from the store.
+func (s *GenericStore[T, PT]) GetAll(ctx context.Context) ([]PT, error) {
+	defer s.setPostgresOperationDurationTime(time.Now(), ops.GetAll)
+
+	var objs []PT
+	err := s.Walk(ctx, func(obj PT) error {
+		objs = append(objs, obj)
+		return nil
+	})
+	return objs, err
+}
diff --git a/tools/generate-helpers/pg-table-bindings/store.go.tpl b/tools/generate-helpers/pg-table-bindings/store.go.tpl
@@ -727,21 +727,6 @@ func (s *storeImpl) GetIDs(ctx context.Context) ([]{{$singlePK.Type}}, error) {
 }
 {{- end }}
 
-{{- if .GetAll }}
-
-// GetAll retrieves all objects from the store.
-func(s *storeImpl) GetAll(ctx context.Context) ([]*{{.Type}}, error) {
-	defer metrics.SetPostgresOperationDurationTime(time.Now(), ops.GetAll, "{{.TrimmedType}}")
-
-    var objs []*{{.Type}}
-    err := s.Walk(ctx, func(obj *{{.Type}}) error {
-        objs = append(objs, obj)
-        return nil
-    })
-    return objs, err
-}
-{{- end}}
-
 //// Interface functions - END
 
 //// Used for testing

diff --git a/tools/generate-helpers/pg-table-bindings/test/postgres/store.go b/tools/generate-helpers/pg-table-bindings/test/postgres/store.go
diff --git a/tools/generate-helpers/pg-table-bindings/testuuidkey/postgres/store.go b/tools/generate-helpers/pg-table-bindings/testuuidkey/postgres/store.go