Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pin certifi due to importlib-resources import failure #48

Merged
merged 4 commits into from Sep 22, 2022
Merged

fix: pin certifi due to importlib-resources import failure #48

merged 4 commits into from Sep 22, 2022

Conversation

thisisshi
Copy link
Collaborator

@thisisshi thisisshi commented Sep 22, 2022 •
edited

seems like this change: certifi/python-certifi#199 broke it though im not entirely sure why, reverting to a previous version fixes it

@thisisshi thisisshi marked this pull request as ready for review September 22, 2022 18:42
@thisisshi thisisshi requested a review from a team as a code owner September 22, 2022 18:42
@thisisshi thisisshi requested review from johnsca and removed request for a team September 22, 2022 18:42
@thisisshi thisisshi changed the title fix: add importlib resources explicitly fix: pin certifi due to importlib-resources import failure Sep 22, 2022
@thisisshi thisisshi merged commit 6b8555b into main Sep 22, 2022
@ghost ghost deleted the fix-importlib-resources branch April 27, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howbazaar howbazaar howbazaar approved these changes

@johnsca johnsca Awaiting requested review from johnsca johnsca was automatically assigned from stacklet/platform-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thisisshi @howbazaar