Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Bump dependencies #431

Merged
merged 6 commits into from May 13, 2024
Merged

chore: Bump dependencies #431

merged 6 commits into from May 13, 2024

Conversation

NickLarsenNZ
Copy link
Member

Description

  • Bump operator-rs, and external crates
    • Fix broken code
  • regenerate-nix

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. CRD documentation for all fields, following the style guide.
    Options
  4. Helm chart can be installed and deployed operator works
    Options
  5. Integration tests passed (for non trivial changes)
    Options
  6. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. Code contains useful logging statements
    Options
  3. (Integration-)Test cases added
    Options
  4. Documentation added or updated. Follows the style guide.
    Options
  5. Changelog updated
    Options
  6. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options
  3. Roadmap has been updated
    Options

@NickLarsenNZ NickLarsenNZ self-assigned this May 10, 2024
@razvan razvan self-requested a review May 13, 2024 07:15
sbernauer
sbernauer reviewed May 13, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
razvan
razvan previously approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sbernauer
sbernauer approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but I would @nightkr review the h2 stuff

@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 8d456d7 May 13, 2024
30 checks passed
@NickLarsenNZ NickLarsenNZ deleted the chore/bump-deps branch May 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

@razvan razvan razvan left review comments

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickLarsenNZ @razvan @sbernauer