Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stackable-webhook): Explicitly set the TLS provider for the ServerConfig, and enable "safe" protocols #778

Merged
merged 4 commits into from May 24, 2024
Merged

fix(stackable-webhook): Explicitly set the TLS provider for the ServerConfig, and enable "safe" protocols #778

merged 4 commits into from May 24, 2024
+20 −2

Conversation

NickLarsenNZ
Copy link
Member

@NickLarsenNZ NickLarsenNZ commented May 7, 2024 •
edited

Rustls now requires a global provider to be set, or explicitly passed in via the server/client config.

Normally this would be set by the application, and not in a library, however this library is to remove so much boiler plate from our applications.

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. Integration tests passed (for non trivial changes)
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. (Integration-)Test cases added
    Options
  3. Documentation added or updated
    Options
  4. Changelog updated
    Options
  5. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options

@NickLarsenNZ
fix(stackable-webhook): rustls now requires a global provider to be s…
a431702 
…et, or explicity pass in via the server/client config.

Normally this would be set by the application, and not in a library, however this library is to remove so much boiler plate from our applications.
@NickLarsenNZ NickLarsenNZ requested a review from Techassi May 7, 2024 14:23
@NickLarsenNZ NickLarsenNZ self-assigned this May 7, 2024
@NickLarsenNZ NickLarsenNZ changed the title fix(stackable-webhook): pass a tls provider in the ServerConfig fix(stackable-webhook): Pass a tls provider in the ServerConfig May 7, 2024
@NickLarsenNZ NickLarsenNZ changed the title fix(stackable-webhook): Pass a tls provider in the ServerConfig fix(stackable-webhook): Explicitly set the TLS provider for the ServerConfig, and enable "safe" protocols May 7, 2024
Techassi
Techassi previously approved these changes May 15, 2024
View reviewed changes
crates/stackable-webhook/src/tls.rs Outdated Show resolved Hide resolved
@NickLarsenNZ NickLarsenNZ added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit f2f1b6b May 24, 2024
17 checks passed
@NickLarsenNZ NickLarsenNZ deleted the fix/webhook-tls-provider branch May 24, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Techassi Techassi Techassi approved these changes

Assignees

@NickLarsenNZ NickLarsenNZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NickLarsenNZ @Techassi