Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying additional extensions to load in Druid #547

Merged
merged 17 commits into from
May 2, 2024
Merged

Allow specifying additional extensions to load in Druid #547

merged 17 commits into from
May 2, 2024

Conversation

labrenbe
Copy link
Member

@labrenbe labrenbe commented Apr 30, 2024 •
edited by sbernauer

Description

Closes #490

Currently the only way to enable additional extensions is to use config overrides potentially removing extension that were added to the extension load based by the operator

This PR adds a field additionalExtensions to clusterConfig containing a simple list of extension names. Extra configuration required by additional extensions is not in scope of this PR.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Edit tasklist title
Beta Give feedback Tasklist Author, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Changes are OpenShift compatible
    Options
  2. CRD changes approved
    Options
  3. CRD documentation for all fields, following the style guide.
    Options
  4. Helm chart can be installed and deployed operator works
    Options
  5. Integration tests passed (for non trivial changes)
    Options
  6. Changes need to be "offline" compatible
    Options

Reviewer

Edit tasklist title
Beta Give feedback Tasklist Reviewer, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Code contains useful comments
    Options
  2. Code contains useful logging statements
    Options
  3. (Integration-)Test cases added
    Options
  4. Documentation added or updated. Follows the style guide.
    Options
  5. Changelog updated
    Options
  6. Cargo.toml only contains references to git tags (not specific commits or branches)
    Options

Acceptance

Edit tasklist title
Beta Give feedback Tasklist Acceptance, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Feature Tracker has been updated
    Options
  2. Proper release label has been added
    Options
  3. Roadmap has been updated
    Options

@labrenbe labrenbe linked an issue Apr 30, 2024 that may be closed by this pull request
Improved extension handling #490
Closed
@sbernauer sbernauer self-requested a review April 30, 2024 12:28
sbernauer
sbernauer requested changes May 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As talked offline I pushed the experiment to feat/additional-extensions-review.
We also created kube-rs/kube#1484

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/extensions.rs Outdated Show resolved Hide resolved
sbernauer
sbernauer requested changes May 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
sbernauer
sbernauer previously approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@labrenbe labrenbe enabled auto-merge May 2, 2024 11:59
@labrenbe labrenbe added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit 4ee36b9 May 2, 2024
30 checks passed
@labrenbe labrenbe deleted the feat/additional-extensions branch May 2, 2024 12:11
@sbernauer sbernauer mentioned this pull request May 10, 2024
Merged
@labrenbe labrenbe mentioned this pull request May 10, 2024
Closed
@sbernauer sbernauer mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@labrenbe labrenbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved extension handling
4 participants
@labrenbe @sbernauer @NickLarsenNZ @Techassi