Allow for generic auth headers with pystac + validators #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-dupuy
changed the title
|
@gadomski or @philvarner - could one of you take a look? First contribution to this repo so please let me know if anything is missing. |
Thanks, I'll take a look this week. |
john-dupuy
force-pushed
the
add-auth-headers
branch
from
773a0e0
to
dfc4285
Compare
john-dupuy
commented
Apr 17, 2023
gadomski
requested changes
Apr 20, 2023
|
Thank you for the detailed review @gadomski! I will try to address this soon (likely next week). |
collection or collection_id Add a test to ensure auth headers arg works Move function around Fix mypy and suppress type checks for mocked test Address review comments Fix mypy
john-dupuy
force-pushed
the
add-auth-headers
branch
from
9b39abb
to
1e27dbb
Compare
gadomski
reviewed
Apr 27, 2023
5 tasks
|
Any movement on this 👀 |
gadomski
approved these changes
Feb 13, 2024
gadomski
added a commit
that referenced
this pull request
Feb 14, 2024
gadomski
pushed a commit
that referenced
this pull request
Feb 14, 2024
collection or collection_id Add a test to ensure auth headers arg works Move function around Fix mypy and suppress type checks for mocked test Address review comments Fix mypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to build off of stac-utils/pystac#889 so that generic auth headers can be added to
stac-api-validatorand dependent requests that are made bypystac.--auth-headersclick option that can take a generic auth header dict as a string and attach it to dependent requestsstac_ioof the pystacCatalogso that the headers will be used as the catalog gets "walked"pystacversion so that Add a mechanism for adding headers to StacIO requests pystac#889 is includedtypeguardto3.0.2TODO: