Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't transform_href in __getstate__ #1337

Merged
merged 2 commits into from
May 3, 2024

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 2, 2024

Related Issue(s):

Description:

__getstate__ was doing too much work by trying to resolve the root. @jsignell we'll want to release a PATCH once this merges, as this will be a good fix to get out in the wild.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@gadomski gadomski requested a review from jsignell May 2, 2024 16:28
@gadomski gadomski self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.22%. Comparing base (3432392) to head (45577b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   91.22%   91.22%           
=======================================
  Files          51       51           
  Lines        7043     7043           
  Branches     1008     1008           
=======================================
  Hits         6425     6425           
  Misses        443      443           
  Partials      175      175           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks Pete 🚀

@gadomski gadomski added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit 9467ac1 May 3, 2024
24 checks passed
@gadomski gadomski deleted the issues/1336-copy-unresolveable-root branch May 3, 2024 12:11
@gadomski gadomski mentioned this pull request May 3, 2024
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request May 3, 2024
* fix: don't transform_href in __getstate__ (#1337)

* release: v1.10.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New pickling methods loads all absolute links
2 participants