PDO: Added PDO::FETCH_CLASS support on fetch*(), fetchObject()
#304
Conversation
|
@Seldaek could you double check this one matches your expectations? just verifying the test-expectations would be enough for now. |
| $all = $stmt->fetchAll(PDO::FETCH_CLASS); | ||
| assertType('array<int, stdClass>', $all); |
There was a problem hiding this comment.
Looks all good to me, but just to make sure, a simple fetch() here would return stdClass|false, right? Might be worth adding for completeness.
There was a problem hiding this comment.
fetch() without args depends on a previous setFetchMode(), which needs #258 and which in turn waits for the next phpstan release
There was a problem hiding this comment.
Ok I see, great to see it all coming together :)
There was a problem hiding this comment.
The tricky part was figuring out how this stateful apis can work in phpstan context.
I don't know any extension which did this before, so this is kind of an achievement
refs #269