Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qastle 0.10 #149

Merged
merged 4 commits into from Mar 15, 2021
Merged

Update qastle 0.10 #149

merged 4 commits into from Mar 15, 2021

Conversation

BenGalewsky
Copy link
Contributor

Problem

Qastle library has been upgraded to 0.10 we need to update the frontend to pull this in otherwise we can get incompatible requirements.

Also, a change in the idna library breaks the requests dependency. As shown in psf/requests#5710

Approach

It seems that for a library of libraries like this one it makes sense to be generous with dependency requirements and not pin them down too tightly. Changed the requirement to be qastle>=0.10

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #149 (89f024d) into master (29b475d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files          10       11    +1     
  Lines         805      810    +5     
=======================================
+ Hits          799      804    +5     
  Misses          6        6           
Flag Coverage Δ
unittests 99.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
servicex/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b475d...89f024d. Read the comment docs.

setup.py Show resolved Hide resolved
@BenGalewsky BenGalewsky merged commit 6cb7209 into master Mar 15, 2021
@BenGalewsky BenGalewsky deleted the update_qastle_0.10 branch March 15, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants