Target .NET Core 3.0 & 3.1 #676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with Base Repository
Update from source repository
|
Hi, can you tell me how to pass the checks? mine failed It has nothing to do with my changes |
|
any luck with DOTNET 5? |
|
This PR is empty (branch reset?) and we are discussing adding targets in #665 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added netcore3.0 and netcore3.1 targets to project build and modified the #if for the new targets.
This should be a completely non-breaking change that allows future use of the new and recommended Task Asyncronous Programming[1] pattern directly.
There was a partial (incorrect imho) targetting of netstandard2.1 in the existing code. The #ifs only conditioned on NETSTANDARD2_0. I expanded those to include NETSTANDARD2_0 || NETSTANDARD2_1 || NETCOREAPP3_0 || NETCOREAPP3_1. That could potentialy be a breaking change. (It's not.)
[1] https://docs.microsoft.com/en-us/dotnet/standard/asynchronous-programming-patterns/task-based-asynchronous-pattern-tap