Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps version of rust-argon2 #57

Merged
merged 1 commit into from Dec 29, 2022
Merged

Conversation

sts10
Copy link
Contributor

@sts10 sts10 commented Oct 3, 2022

Github informed me of a security issue on Medic, namely "crossbeam-utils Race Condition vulnerability", linking to this merge.

After some digging in cargo tree, I learned that keepass-xc depends on rust-argon2, which depends on crossbeam-utils.

Luckily, I think version 1.0 of rust-argon2 seems to use a safe version of crossbeam-utils ("0.8"). This PR simply bumps keepass-rs's rust-argon2 dependency to v 1.0. Tests pass.

@sts10
Copy link
Contributor Author

sts10 commented Oct 3, 2022

Ah, running cargo tree on my fork shows that rust-argon2 is still using crossbeam-utils v0.8.12. My security warning on Medic says I need to use v0.8.7.

I feel like I don't quite understand how Cargo handles dependency versions, since I thought version = "0.8" would automatically use v0.8.7.

@sseemayer sseemayer merged commit f388183 into sseemayer:master Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 29, 2022
sseemayer pushed a commit that referenced this pull request Dec 30, 2022
@sts10 sts10 deleted the upgrade_argon2 branch January 6, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants