New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps version of rust-argon2 #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace Condition vulnerability
Ah, running I feel like I don't quite understand how Cargo handles dependency versions, since I thought |
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 29, 2022
…ace Condition vulnerability (#57)
sseemayer
pushed a commit
that referenced
this pull request
Dec 30, 2022
…ace Condition vulnerability (#57)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github informed me of a security issue on Medic, namely "crossbeam-utils Race Condition vulnerability", linking to this merge.
After some digging in
cargo tree
, I learned that keepass-xc depends on rust-argon2, which depends on crossbeam-utils.Luckily, I think version 1.0 of rust-argon2 seems to use a safe version of crossbeam-utils ("0.8"). This PR simply bumps keepass-rs's rust-argon2 dependency to v 1.0. Tests pass.