Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSR12/FileHeader: bug fix - false positives on PHP 8.2+ readonly classes #3816

Merged
merged 1 commit into from May 22, 2023
Merged

PSR12/FileHeader: bug fix - false positives on PHP 8.2+ readonly classes #3816

merged 1 commit into from May 22, 2023

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented May 3, 2023

As reported in #3799 (comment), the FileHeader sniff did not take the new PHP 8.2+ readonly OO modifier keyword into account.

Fixed now.

Includes test.

@jrfnl
PSR12/FileHeader: bug fix - false positives on PHP 8.2+ readonly classes
6891c04 
As reported in #3799 (comment), the `FileHeader` sniff did not take the new PHP 8.2+ `readonly` OO modifier keyword into account.

Fixed now.

Includes test.
@jrfnl jrfnl added the Type: bug label May 3, 2023
@jrfnl jrfnl added this to the 3.8.0 milestone May 3, 2023
This was referenced May 3, 2023
Open
Closed
@martinjoiner
Copy link

I would love to see this PR merged. Can I can offer any support @jrfnl ?

@jrfnl
Copy link
Contributor Author

jrfnl commented May 16, 2023

@martinjoiner It's on the list of priority PRs we are working our way through. For now, please be patient as there is a lot of backlog to work through. Also see #3814

@jrfnl
Copy link
Contributor Author

jrfnl commented May 16, 2023

@martinjoiner Oh and testing PRs to verify they work as you expect them to and leaving a comment with your test finding is always helpful.
You can test PRs either by checking out the PR branch or by downloading the PHAR file for the PR created by the test workflows in GH Actions.

gsherwood added a commit that referenced this pull request May 22, 2023
@gsherwood
Changelog for #3816
2e59060
@gsherwood gsherwood merged commit e1af9d7 into master May 22, 2023
52 of 54 checks passed
@gsherwood gsherwood deleted the php-8.2/psr12-fileheader-fix-handling-of-readonly-classes branch May 22, 2023 23:18
@jrfnl jrfnl mentioned this pull request Nov 24, 2023
Closed
10 tasks
@jrfnl
Copy link
Contributor Author

jrfnl commented Dec 8, 2023

FYI: this fix is included in today's PHP_CodeSniffer 3.8.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

@martinjoiner
Copy link

A sterling effort! I hope one day to contribute more to the project in its new location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredden fredden fredden approved these changes

Assignees
No one assigned
Labels
Focus: Modern PHP Standard: PSR12 Type: bug
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrfnl @martinjoiner @fredden @gsherwood