Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$data variable should be array #3741

Closed
wants to merge 1 commit into from

Conversation

juanpgarciac
Copy link

in some analysis, I was receiving this error "Uncaught TypeError: vsprintf(): Argument #2 ($values) must be of type array, string given" on line 1056

in some analysis, I was receiving this error "Uncaught TypeError: vsprintf(): Argument squizlabs#2 ($values) must be of type array, string given" on line 1056
@jrfnl
Copy link
Contributor

jrfnl commented Jan 9, 2023

@juanpgarciac Thanks for your willingness to contribute.

In my opinion, this is the wrong fix. This should be fixed at the point where this function is being passed incorrect information by a call to File::addError() or File::addWarning(), not here.
If anything, the $data parameter here should probably get an array type declaration (in the File::addMessage() et al function signatures).

@juanpgarciac
Copy link
Author

Ok, agreed. I will check on your suggestion later on. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants