Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic/CharacterBeforePHPOpeningTag: prevent false positive in mixed PHP/HTML files #3704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Generic/CharacterBeforePHPOpeningTag: prevent false positive in mixed PHP/HTML files #3704

wants to merge 1 commit into from

Commits on Nov 2, 2022

  1. Generic/CharacterBeforePHPOpeningTag: prevent false positive in mixed… 

    … PHP/HTML files

When a file would contain a short open echo tag `<?=` before a full PHP tag `<?php`, the sniff would throw a "The opening PHP tag must be the first content in the file" error, which IMO is a false positive.

Fixed now.

Includes additional tests demonstrating the issue and safeguarding the fix.
    @jrfnl
    jrfnl committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    c9b6d1f View commit details
    Browse the repository at this point in the history