Squiz.Scope.MethodScope misses visibility keyword on previous line #3575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Squiz.Scope.MethodScope` sniff is intended to check whether each method has visibility declared, but would in actual fact also enforce that the visibility should be on the same line as the `function` keyword as it stopped searching for the visibility keyword once it reached the start of the line. Fixed now by using the `File::getMethodProperties()` method for determining visibility instead of searching with sniff specific logic. Includes unit test.
gsherwood
changed the title
|
A nice clean fix to the problem. Thanks for fixing it. |
jrfnl
deleted the
feature/squiz-methodscope-handle-unconventional-spacing
branch
|
Happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Squiz.Scope.MethodScopesniff is intended to check whether each method has visibility declared, but would in actual fact also enforce that the visibility should be on the same line as thefunctionkeyword as it stopped searching for the visibility keyword once it reached the start of the line.Fixed now by using the
File::getMethodProperties()method for determining visibility instead of searching with sniff specific logic.Includes unit test.