PHP 8.1 | PSR12/ConstantVisibility: allow for class constants to be final
#3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 5, 2022
Closed
Closed
…final` PHP 8.1 introduces the ability to declare class constants as `final`. The tokenization of the `final` keyword in this context appears to be consistent PHPCS cross-version, so AFAICS no changes are needed to the PHP tokenizer. However, the `PSR12.Properties.ConstantVisibility` sniff does need to allow for them. Includes unit tests. Ref: https://wiki.php.net/rfc/final_class_const
jrfnl
force-pushed
the
feature/3526-psr12-constantvisibility-bug-fix-final
branch
from
7c2d3b1
to
1b1fc31
Compare
|
Rebased to get a passing build. |
|
Thanks for fixing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 introduces the ability to declare class constants as
final.The tokenization of the
finalkeyword in this context appears to be consistent PHPCS cross-version, so AFAICS no changes are needed to the PHP tokenizer.However, the
PSR12.Properties.ConstantVisibilitysniff does need to allow for them.Includes unit tests.
Ref: https://wiki.php.net/rfc/final_class_const
Fixes #3526
Related to #3479
Notes:
T_CONSTtoken and could not find any other sniffs which would need adjusting for this PHP change.