Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEAR/FunctionDeclaration: ignore multi-line attributes for promoted properties #3427

Merged
merged 2 commits into from Sep 27, 2021
Merged

PEAR/FunctionDeclaration: ignore multi-line attributes for promoted properties #3427

merged 2 commits into from Sep 27, 2021

Commits on Sep 5, 2021

  1. PEAR/FunctionDeclaration: ignore multi-line promoted properties 

    Similar to (multi-line) arrays in a multi-line function declaration, ignore (multi-line) attributes for the purposes of the indentation checks in this sniff.

This does mean that inconsistent indentation within multi-line attributes/ for an attribute closer will not be fixed, but that should be handled by a dedicated attribute formatting sniff in my opinion.

Includes unit tests.

Fixes 3424
    @jrfnl
    jrfnl committed Sep 5, 2021
    Copy the full SHA
    074622b View commit details
    Browse the repository at this point in the history

  2. PEAR/FunctionDeclaration: minor efficiency tweak

    @jrfnl
    jrfnl committed Sep 5, 2021
    Copy the full SHA
    18c5d6f View commit details
    Browse the repository at this point in the history