PHP 8.0 | Squiz.WhiteSpace.MemberVarSpacing: add support for attributes #3334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
May 6, 2021
|
|
||
|
|
||
| private $var3 = 'value'; | ||
| } |
There was a problem hiding this comment.
Just some suggestions:
- What about a test case where the attribute is before the docblock ?
- What about a test case with one attribute on the same line as the property ?
- What about a test case with two attributes on the same line as the property ?
Would be good to verify that the sniff will handle those cases correctly as well.
There was a problem hiding this comment.
Despite there is no PSR for Attributes for now, I suggest to always keep phpDoc before attributes.
yariknechyporuk
force-pushed
the
master
branch
from
c83955a
to
6401ea1
Compare
|
For visibility: there's a discussion open about this PR here: #3419 |
|
FYI: PR #3440 tries to address the same issue, but without changing the base behaviour of the sniff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.