Changelog + test fixes for #2639 (ref #2638)

squizlabs · Oct 30, 2019 · 7f1ee75 · 7f1ee75
1 parent 216455e
commit 7f1ee75
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/package.xml b/package.xml
@@ -26,6 +26,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
  </stability>
  <license uri="https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt">BSD 3-Clause License</license>
  <notes>
+  - Fixed bug #2638 : Squiz.CSS.DuplicateClassDefinitionSniff sees comments as part of the class name
+    -- Thanks to Raphael Horber for the patch
   - Fixed bug #2674 : Squiz.Functions.FunctionDeclarationArgumentSpacing prints wrong argument name in error message
  </notes>
  <contents>

diff --git a/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.css b/src/Standards/Squiz/Tests/CSS/DuplicateClassDefinitionUnitTest.css
@@ -74,30 +74,30 @@
 
 /* print comment */
 @media print {
-    /* any comment */
+    /* comment1 */
     td {
     }
 
-    /* any comment */
+    /* comment2 */
     img {
     }
 
-    /* any comment */
+    /* comment3 */
     td {
     }
 }
 
 @media handheld /* handheld comment */
 {
-    td /* any comment */
+    td /* comment1 */
     {
     }
 
-    img /* any comment */
+    img /* comment2 */
     {
     }
 
-    td /* any comment */
+    td /* comment3 */
     {
     }
 }