Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added note on importance of site_url #7103

Merged
merged 2 commits into from Apr 28, 2024
Merged

Conversation

alexvoss
Copy link
Sponsor Collaborator

this was in response to
#4678 (comment)

@alexvoss alexvoss requested a review from squidfunk April 26, 2024 06:33
@@ -44,6 +44,22 @@ theme:
name: material
```

Note that by default, MkDocs will assume that your site is hosted at the root of
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We should add that the site_url setting is strongly recommended from our perspective, as without it, several features will not work, including instant loading and previews, as well as social cards.

@alexvoss alexvoss requested a review from squidfunk April 27, 2024 15:44
Copy link
Owner

@squidfunk squidfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@squidfunk squidfunk merged commit c427e1c into squidfunk:master Apr 28, 2024
4 checks passed
@squidfunk squidfunk deleted the site_url branch April 28, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants