Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures being rendered on inline/block code elements #4381

Closed
5 tasks done
layoaster opened this issue Sep 19, 2022 · 3 comments
Closed
5 tasks done

Ligatures being rendered on inline/block code elements #4381

layoaster opened this issue Sep 19, 2022 · 3 comments
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open

Comments

@layoaster
Copy link

layoaster commented Sep 19, 2022

Contribution guidelines

I've found a bug and checked that ...

  • ... the problem doesn't occur with the mkdocs or readthedocs themes
  • ... the problem persists when all overrides are removed, i.e. custom_dir, extra_javascript and extra_css
  • ... the documentation does not mention anything about my problem
  • ... there are no open or closed issues that are related to my problem

Description

The issue got fixed long time ago but it's happening again. It affects both block & inline code elements.

Expected behaviour

Have monospaced fonts rendered without ligatures like on github:

<region>-realtime
Druid datasource
<region>-realtime

Actual behaviour

Ligatures are being rendered:

image

Steps to reproduce

  1. Using JetBrains Mono for code elements.
  2. Input any pair of characters like -> or -< ligature in a block of code or inline.

Package versions

  • Python: python --version: 3.9.13
  • MkDocs: mkdocs --version: 1.3.1
  • Material: pip show mkdocs-material | grep -E ^Version: 8.5.2

Configuration

site_name: "EA"
site_url: null
repo_name: null
repo_url: null
edit_uri: null

theme:
  name: material
  # Colors
  palette:
    - scheme: default
      toggle:
        icon: material/lightbulb-outline
        name: Switch to dark mode
      primary: indigo
      accent: blue
    - scheme: slate
      toggle:
        icon: material/lightbulb
        name: Switch to light mode
      primary: brown
      accent: orange
  # Fonts
  font:
    text: Roboto
    code: JetBrains Mono

  features:
    - navigation.instant
    - navigation.sections
    - navigation.tabs
    - navigation.expand
    - navigation.top
    - search.suggest
    - search.highlight
    - toc.integrate

System information

  • Operating system: Linux/Ubuntu
  • Browser: Firefox
@squidfunk
Copy link
Owner

Thanks for reporting. Indeed, that's unintended. Fixed in dcab57d.

@squidfunk squidfunk added the resolved Issue is resolved, yet unreleased if open label Sep 19, 2022
@squidfunk
Copy link
Owner

By the way, funnily, monospace fonts still have no "liga" set on font-feature-settings:

font-feature-settings: "kern";

So, effectively, we changed nothing for the last 5 years 😅

@squidfunk squidfunk added the bug Issue reports a bug label Sep 19, 2022
@squidfunk
Copy link
Owner

Released as part of 8.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue reports a bug resolved Issue is resolved, yet unreleased if open
Projects
None yet
Development

No branches or pull requests

2 participants