Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding with shards docs #530

Merged
merged 4 commits into from Feb 1, 2023
Merged

Coding with shards docs #530

merged 4 commits into from Feb 1, 2023

Conversation

ChelseaChX
Copy link
Contributor

2nd Draft of the Coding with Shards primer chapter

  • Fixed images.
  • Reworked the segments on shards, defshards, Wires, Meshes.
  • Added segment on scheduling shards, running shards, and writing a sample program.
  • Fixed hyperlinks for assets.

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #530 (5f511bd) into devel (f4016cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 5f511bd differs from pull request most recent head d7c86ee. Consider uploading reports for the commit d7c86ee to get more accurate results

@@           Coverage Diff           @@
##            devel     #530   +/-   ##
=======================================
  Coverage   81.35%   81.35%           
=======================================
  Files         243      243           
  Lines       30180    30180           
=======================================
  Hits        24554    24554           
  Misses       5626     5626           
Impacted Files Coverage Δ
src/core/shards/inlined.cpp 97.54% <0.00%> (-2.46%) ⬇️
src/core/shards/flow.hpp 88.00% <0.00%> (-0.17%) ⬇️
src/core/shards/network.cpp 92.82% <0.00%> (+1.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@Kryptos-FR Kryptos-FR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few remarks but overall good.

docs/docs/learn/shards/coding-with-shards.md Outdated Show resolved Hide resolved
docs/docs/learn/shards/coding-with-shards.md Outdated Show resolved Hide resolved
docs/docs/learn/shards/coding-with-shards.md Outdated Show resolved Hide resolved
docs/docs/learn/shards/coding-with-shards.md Outdated Show resolved Hide resolved
docs/docs/learn/shards/coding-with-shards.md Outdated Show resolved Hide resolved
docs/docs/learn/shards/coding-with-shards.md Outdated Show resolved Hide resolved
- Fixed images.
- Reorganized the segments on shards, defshards, Wires.
- Added segment on scheduling shards, running shards, and writing a sample program.
- Fixed hyperlinks for wrong assets
…changes, fixed integer usage for the segment on frame rates, changed brackets to parenthesis.
Replace `brackets` with `parentheses` in one more place.
@Kryptos-FR Kryptos-FR merged commit 8e4e6c5 into devel Feb 1, 2023
@Kryptos-FR Kryptos-FR deleted the coding-with-shards-docs branch February 1, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants