Add use-site target field to custom options annotation spec #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvinsee
force-pushed
the
alvin/wire-custom-options-annotation-target
branch
from
4b78a20
to
bbc7da4
Compare
oldergod
reviewed
Mar 7, 2024
wire-kotlin-generator/src/main/java/com/squareup/wire/kotlin/KotlinGenerator.kt
Outdated
Show resolved
Hide resolved
wire-tests/src/commonTest/proto-kotlin/com/squareup/wire/protos/custom_options/FooBar.kt
Show resolved
Hide resolved
alvinsee
force-pushed
the
alvin/wire-custom-options-annotation-target
branch
from
c8c73ca
to
70caa8a
Compare
|
I don’t like doubling up the amount of generated code here. Is it already available via reflection on the getter? |
|
Can we make these all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a use-site target for fields in the kotlin generated classes. This enables the annotations targeted for a field to be available through the java field via reflection.