Infer the Kotlin type of bind parameter, if possible, or fail with a … #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better error message
AlecKazakova
approved these changes
Aug 6, 2022
|
This might also fix the following, right? CREATE TABLE directory (
id TEXT NOT NULL PRIMARY KEY,
refreshOnStartUp INTEGER AS Boolean
);
CREATE TABLE channel (
id TEXT NOT NULL PRIMARY KEY,
refreshOnStartUp INTEGER AS Boolean,
directoryId TEXT
);
myQuery:
SELECT channel.*
FROM channel
LEFT JOIN directory
ON channel.directoryId = directory.id
WHERE COALESCE(channel.refreshOnStartUp, directory.refreshOnStartUp, :refreshOnStartUp) = 1
;Currently, I'm getting: |
|
@vanniktech Nope, because coalesce supports many different sql types: But you will get a better error message indicating you to use CAST :D |
|
Alright, I ended up casting now anyways. Would not it still be possible to infer the type? Both Also, I can't seem to write I need to use |
|
Maybe it is possible to infer the kotlin type with multiple possible sql types too, when the corresponding sql type have the same kotlin representation, eg tiny int uses Int/Long not Short etc Update: They do use different Kotlin types |
@vanniktech Yes, it must be valid SQL, not sqldelight AS Kotlin
Sounds possible, but I would also emit a warning
|
|
Why the warning? You can see the return type in the generated code. |
|
Okay, that's true :D I'd just prevent wrong questions a la "my Kotlin type is wrong" because people forget CAST, including me |
Closed
|
Created #3416 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…better error message
Fixes #3407 with a better error message
The compiler can now infer the Kotlin type of a bind parameter, if
encapsulatingTypehas exactly 1 sql type. This is used forCONCAT: egsqldelight/dialects/mysql/src/main/kotlin/app/cash/sqldelight/dialects/mysql/MySqlTypeResolver.kt
Line 55 in 02edf13