Infer the Kotlin type of bind parameter, if possible, or fail with a …

…better error message (#3413)

Co-authored-by: hfhbd <hfhbd@users.noreply.github.com>

sqldelight-compiler/dialect/src/main/kotlin/app/cash/sqldelight/dialect/api/TypeResolver.kt

@@ -57,7 +57,11 @@ fun TypeResolver.encapsulatingType(
   val types = exprList.map { resolvedType(it) }
   val sqlTypes = types.map { it.dialectType }
 
-  val type = typeOrder.last { it in sqlTypes }
+  val type = typeOrder.lastOrNull { it in sqlTypes }
+    ?: if (PrimitiveType.ARGUMENT in sqlTypes && typeOrder.size == 1) {
+      return IntermediateType(typeOrder.single())
+    } else error("The Kotlin type of the argument cannot be inferred, use CAST instead.")
+
   if (!nullableIfAny && types.all { it.javaType.isNullable } ||
     nullableIfAny && types.any { it.javaType.isNullable }
   ) {

sqldelight-compiler/src/test/kotlin/app/cash/sqldelight/core/BindArgsTest.kt

@@ -14,6 +14,7 @@ import com.squareup.kotlinpoet.asClassName
 import org.junit.Rule
 import org.junit.Test
 import org.junit.rules.TemporaryFolder
+import kotlin.test.assertFailsWith
 
 class BindArgsTest {
   @get:Rule val tempFolder = TemporaryFolder()
@@ -284,6 +285,28 @@ class BindArgsTest {
     }
   }
 
+  @Test fun `bind arg kotlin type cannot be inferred with ambiguous sql parameter types`() {
+    val file = FixtureCompiler.parseSql(
+      """
+      |CREATE TABLE dummy(
+      |  foo INTEGER
+      |);
+      |
+      |maxSupportsManySqlTypes:
+      |SELECT 1
+      |FROM dummy
+      |WHERE MAX(:input) > 1;
+      """.trimMargin(),
+      tempFolder,
+    )
+
+    val errorMessage = assertFailsWith<IllegalStateException> {
+      file.findChildrenOfType<SqlBindExpr>().single().argumentType()
+    }
+    assertThat(errorMessage.message)
+      .isEqualTo("The Kotlin type of the argument cannot be inferred, use CAST instead.")
+  }
+
   @Test fun `bind args use proper binary operator precedence`() {
     val file = FixtureCompiler.parseSql(
       """

sqldelight-gradle-plugin/src/test/custom-dialect/src/main/sqldelight/schema/Foo.sq

@@ -4,3 +4,6 @@ id INTEGER
 
 selectFooWithId:
 SELECT foo(id) FROM foo;
+
+inferredType:
+SELECT 1 FROM foo WHERE foo(:inferred) NOT NULL;

sqldelight-gradle-plugin/src/test/custom-dialect/src/test/kotlin/Testing.kt

@@ -0,0 +1,31 @@
+import app.cash.sqldelight.Query
+import app.cash.sqldelight.driver.jdbc.JdbcDriver
+import org.junit.Test
+import schema.FooQueries
+import java.sql.Connection
+import kotlin.time.Duration
+import kotlin.time.Duration.Companion.seconds
+
+class Testing {
+  @Test fun inferredCompiles() {
+    val fakeDriver = object : JdbcDriver() {
+      override fun getConnection() = TODO()
+      override fun closeConnection(connection: Connection) = Unit
+      override fun addListener(listener: Query.Listener, queryKeys: Array<String>) = Unit
+      override fun removeListener(listener: Query.Listener, queryKeys: Array<String>) = Unit
+      override fun notifyListeners(queryKeys: Array<String>) = Unit
+    }
+    FooQueries(fakeDriver).inferredType(1.seconds)
+  }
+
+  @Test fun customFunctionReturnsDuration() {
+    val fakeDriver = object : JdbcDriver() {
+      override fun getConnection() = TODO()
+      override fun closeConnection(connection: Connection) = Unit
+      override fun addListener(listener: Query.Listener, queryKeys: Array<String>) = Unit
+      override fun removeListener(listener: Query.Listener, queryKeys: Array<String>) = Unit
+      override fun notifyListeners(queryKeys: Array<String>) = Unit
+    }
+    val unused: Duration = FooQueries(fakeDriver).selectFooWithId().executeAsOne()
+  }
+}

sqldelight-gradle-plugin/src/test/kotlin/app/cash/sqldelight/dialect/DialectIntegrationTests.kt

@@ -53,7 +53,7 @@ class DialectIntegrationTests {
   @Test fun customFunctionDialect() {
     val runner = GradleRunner.create()
       .withCommonConfiguration(File("src/test/custom-dialect"))
-      .withArguments("clean", "assemble", "--stacktrace")
+      .withArguments("clean", "compileTestKotlin", "--stacktrace")
 
     val result = runner.build()
     Truth.assertThat(result.output).contains("BUILD SUCCESSFUL")