Update gson to its latest version #3651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please keep in mind that we do not release new versions of this library solely to bump dependencies–even for vulnerabilities. As a consumer you should not rely on our transitive dependency to dictate the version of the serialization library and should instead maintain a sibling dependency on the version you desire (and be keeping that up to date). E.g., implementation 'com.squareup.retrofit:retrofit2:2.9.0'
implementation 'com.squareup.retrofit:converter-gson:2.9.0'
implementation 'com.google.gson:gson:2.8.9' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
We noticed that using Snyk that our CI would fail due to the following warning raised by Snyk saying the current version gson that Retrofit uses is a high severity issue.
There are temporary ways to get around this with Snyk, but the permanent solution would be for Retrofit to upgrade to the latest version of gson to resolve this issue.
The issue raised in the gson repository Prevent Java deserialization of internal classes google/gson#1991
Fixed in this release https://github.com/google/gson/releases/tag/gson-parent-2.8.9
Snyks warning https://snyk.io/vuln/SNYK-JAVA-COMGOOGLECODEGSON-1730327
Closes #3652