Introduce Timeout.waitUntil(monitor, condition: () -> Boolean) #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
martinbonnin
force-pushed
the
add-waituntil
branch
from
3d0a173
to
4302b95
Compare
|
If we go ahead with #1176, might be worth waiting on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
waitUntilNotifiedexcept it accounts for spurious wake ups and bad timer resolutions.Use it in
Pipewhere the bad timer resolution on Windows could make thePipewait way longer than it should because thewaitwould return a few nanoseconds early very often and the read/write loop would continue looping, waiting several times the nominal Timeout value