Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralise more locks #8389

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Centralise more locks #8389

wants to merge 6 commits into from

Conversation

yschimke
Copy link
Collaborator

Investigating #8388 - trying to ensure we have a central place to reason about our locks.

@yschimke yschimke marked this pull request as ready for review April 27, 2024 11:04
@yschimke
Copy link
Collaborator Author

The idea is with a central place of inlined locking primitives, I can experiment like

https://github.com/square/okhttp/blob/44dc78f53ee188268f9e8a2a57c9f2537be9b7a9/okhttp/src/main/kotlin/okhttp3/internal/connection/Locks.kt

In ways we will never land, but without a lot of refactoring to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swankjesse swankjesse Awaiting requested review from swankjesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yschimke