Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable fastFallback by default #7566

Merged
merged 2 commits into from Dec 24, 2022
Merged

Enable fastFallback by default #7566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef5fe8c
Enable fastFallback by default
yschimke Dec 24, 2022
40b21c2
Change default
yschimke Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion okhttp-testing-support/src/main/kotlin/okhttp3/OkHttpClientTestRule.kt
View file
Open in desktop
Expand Up @@ -115,7 +115,6 @@ class OkHttpClientTestRule : BeforeEachCallback, AfterEachCallback {
var client = testClient
if (client == null) {
client = OkHttpClient.Builder()
.fastFallback(true) // Test this by default, since it'll soon be the default.
.dns(SINGLE_INET_ADDRESS_DNS) // Prevent unexpected fallback addresses.
.eventListenerFactory { ClientRuleEventListener(logger = ::addEvent) }
.build()
Expand Down
4 changes: 3 additions & 1 deletion okhttp/src/jvmMain/kotlin/okhttp3/OkHttpClient.kt
View file
Open in desktop
Expand Up @@ -512,7 +512,7 @@ open class OkHttpClient internal constructor(
internal val networkInterceptors: MutableList<Interceptor> = mutableListOf()
internal var eventListenerFactory: EventListener.Factory = EventListener.NONE.asFactory()
internal var retryOnConnectionFailure = true
internal var fastFallback = false
internal var fastFallback = true
internal var authenticator: Authenticator = Authenticator.NONE
internal var followRedirects = true
internal var followSslRedirects = true
Expand Down Expand Up @@ -669,6 +669,8 @@ open class OkHttpClient internal constructor(
* This implements Happy Eyeballs ([RFC 6555][rfc_6555]), balancing connect latency vs.
* wasted resources.
*
* Defaults to enabled, call with [fastFallback] = false to revert to 4.x behaviour.
*
* [rfc_6555]: https://datatracker.ietf.org/doc/html/rfc6555
*/
fun fastFallback(fastFallback: Boolean) = apply {
Expand Down