New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve runtime compatibility with kotlin 1.5.31 #7343
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,6 @@ import okhttp3.internal.commonClampToInt | |
import okhttp3.internal.commonForceCache | ||
import okhttp3.internal.commonForceNetwork | ||
import okhttp3.internal.commonImmutable | ||
import okhttp3.internal.commonMaxAge | ||
import okhttp3.internal.commonMaxStale | ||
import okhttp3.internal.commonMinFresh | ||
import okhttp3.internal.commonNoCache | ||
import okhttp3.internal.commonNoStore | ||
import okhttp3.internal.commonNoTransform | ||
|
@@ -153,11 +150,18 @@ actual class CacheControl internal actual constructor( | |
|
||
actual fun immutable() = commonImmutable() | ||
|
||
actual fun maxAge(maxAge: Int, timeUnit: DurationUnit) = commonMaxAge(maxAge, timeUnit) | ||
// We are compiling with kotlin 1.6 but need to run with older versions at runtime. For | ||
// maximum compat we therefore need to handle both the case where DurationUnit is typealiased | ||
// to TimeUnit (as it was pre-1.6) and where it is a distinct wrapper enum (in 1.6). We also | ||
// can't use durationUnit.toTimeUnit() because that doesn't exist in the typealiased case. | ||
// This function should work in either case. | ||
internal fun toJavaTimeUnit(durationUnit: DurationUnit) = TimeUnit.valueOf(durationUnit.name) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This doesn't look to bad, a lookup in a Hashmap, from a constant name (at least on JVM). |
||
|
||
actual fun maxStale(maxStale: Int, timeUnit: DurationUnit) = commonMaxStale(maxStale, timeUnit) | ||
actual fun maxAge(maxAge: Int, timeUnit: DurationUnit) = maxAge(maxAge, toJavaTimeUnit(timeUnit)) | ||
|
||
actual fun minFresh(minFresh: Int, timeUnit: DurationUnit) = commonMinFresh(minFresh, timeUnit) | ||
actual fun maxStale(maxStale: Int, timeUnit: DurationUnit) = maxStale(maxStale, toJavaTimeUnit(timeUnit)) | ||
|
||
actual fun minFresh(minFresh: Int, timeUnit: DurationUnit) = minFresh(minFresh, toJavaTimeUnit(timeUnit)) | ||
|
||
/** | ||
* Sets the maximum age of a cached response. If the cache response's age exceeds [maxAge], it | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, so this is reverting back to before these PRs.