Commits on Dec 4, 2021

1. Fail gracefully when a primitive value is absent. …

   Without this we get an AssertionError, which is the wrong exception
   type for a JSON schema mismatch:
   
       java.lang.AssertionError: java.lang.NullPointerException: Cannot invoke "java.lang.Number.intValue()" because the return value of "sun.invoke.util.ValueConversions.primitiveConversion(sun.invoke.util.Wrapper, Object, boolean)" is null
         at com.squareup.moshi.RecordJsonAdapter.fromJson(RecordJsonAdapter.java:168)
         at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
         at com.squareup.moshi.JsonAdapter.fromJson(JsonAdapter.java:70)
         at com.squareup.moshi.records.RecordsTest.absentPrimitiveFails(RecordsTest.java:257)
       Caused by: java.lang.NullPointerException: Cannot invoke "java.lang.Number.intValue()" because the return value of "sun.invoke.util.ValueConversions.primitiveConversion(sun.invoke.util.Wrapper, Object, boolean)" is null
         at java.base/sun.invoke.util.ValueConversions.unboxInteger(ValueConversions.java:81)
         at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
         at com.squareup.moshi.RecordJsonAdapter.fromJson(RecordJsonAdapter.java:156)
         ... 46 more

   

   swankjesse committed Dec 4, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for fe9a303
   • Browse repository at this point

   Copy the full SHA

   fe9a303 View commit details

   Browse the repository at this point in the history