Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name the thread of the serialExecutor used in the Leak activity #2499

Merged
merged 1 commit into from May 4, 2023
Merged

Name the thread of the serialExecutor used in the Leak activity #2499

merged 1 commit into from May 4, 2023

Conversation

jbiral
Copy link
Contributor

@jbiral jbiral commented Apr 7, 2023

Naming the serialExecutor helps keep track of where threads are coming from within an app.

Otherwise, it is named as pool-N-thread-1, which is unhelpful when debugging.

@jbiral
Name the thread used in the Leak activity
fea25ea 
Naming the serialExecutor helps keep track of where threads are coming from within an app.
@CLAassistant
Copy link

CLAassistant commented Apr 7, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@pyricau
Copy link
Member

pyricau commented May 4, 2023

Thanks you!

@pyricau pyricau merged commit bb02e91 into square:main May 4, 2023
8 checks passed
kikin81
kikin81 reviewed May 4, 2023
View reviewed changes
Copy link

@kikin81 kikin81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kikin81 kikin81 kikin81 left review comments

@pyricau pyricau pyricau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbiral @CLAassistant @pyricau @kikin81