Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore failure to close file #2444

Merged
merged 1 commit into from Nov 11, 2022
Merged

Ignore failure to close file #2444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion shark-hprof/src/main/java/shark/ThrowingCancelableFileSourceProvider.kt
View file
Open in desktop
@@ -1,6 +1,7 @@
package shark

import java.io.File
import java.io.IOException
import okio.Buffer
import okio.BufferedSource
import okio.Okio
Expand Down Expand Up @@ -40,7 +41,13 @@ class ThrowingCancelableFileSourceProvider(
return channel.transferTo(position, byteCount, sink)
}

override fun close() = channel.close()
override fun close() {
try {
channel.close()
} catch (ignored: Throwable) {
SharkLog.d(ignored) { "Failed to close file, ignoring" }
}
}
}
}
}