Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report AnimationHandler leak #2441

Merged
merged 1 commit into from Nov 10, 2022
Merged

Report AnimationHandler leak #2441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions shark-android/api/shark-android.api
View file
Open in desktop
Expand Up @@ -71,6 +71,7 @@ public abstract class shark/AndroidReferenceMatchers : java/lang/Enum {
public static final field ACTIVITY_MANAGER_MCONTEXT Lshark/AndroidReferenceMatchers;
public static final field ACTIVITY_THREAD__M_NEW_ACTIVITIES Lshark/AndroidReferenceMatchers;
public static final field ACTIVITY_TRANSITION_STATE__M_EXITING_TO_VIEW Lshark/AndroidReferenceMatchers;
public static final field ANIMATION_HANDLER__ANIMATOR_REQUESTORS Lshark/AndroidReferenceMatchers;
public static final field APPLICATION_PACKAGE_MANAGER__HAS_SYSTEM_FEATURE_QUERY Lshark/AndroidReferenceMatchers;
public static final field APP_OPS_MANAGER__CALLBACK_STUB Lshark/AndroidReferenceMatchers;
public static final field APP_WIDGET_HOST_CALLBACKS Lshark/AndroidReferenceMatchers;
Expand Down
17 changes: 17 additions & 0 deletions shark-android/src/main/java/shark/AndroidReferenceMatchers.kt
View file
Open in desktop
Expand Up @@ -866,6 +866,23 @@ enum class AndroidReferenceMatchers {
}
},

ANIMATION_HANDLER__ANIMATOR_REQUESTORS {
override fun add(
references: MutableList<ReferenceMatcher>
) {
references += instanceFieldLeak(
"android.animation.AnimationHandler", "mAnimatorRequestors",
description = """
AnimationHandler is a singleton holding an activity ViewRootImpl requestor after the
activity has been destroyed.
Report: https://issuetracker.google.com/issues/258534826
""".trimIndent()
) {
sdkInt == 33
}
}
},

// ######## Manufacturer specific known leaks ########

// SAMSUNG
Expand Down