Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make androidx.startup Initializers public #2397

Merged
merged 2 commits into from Aug 22, 2022

Conversation

fbarthelery
Copy link
Contributor

This allows to use LeakCanary initializers as dependencies using the dependencies() method. As this is an advanced use case and it should not be needed for basic usage, I kept the classes in leakcanary.internal package.

Fixes #2393

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2022

CLA assistant check
All committers have signed the CLA.

@pyricau
Copy link
Member

pyricau commented Jul 8, 2022

As this is an advanced use case and it should not be needed for basic usage, I kept the classes in leakcanary.internal package.

I'd still like to stay consistent and have only internal APIs inside the internal package. Can you move the classes up one level? You'll likely need to update manifest references as well. Thanks!

@pyricau pyricau merged commit af4af60 into square:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making androidx.startup Initializers part of the public API
3 participants