Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in handling JNI roots #1636

Merged
merged 1 commit into from Nov 25, 2019
Merged

Fix bug in handling JNI roots #1636

merged 1 commit into from Nov 25, 2019

Conversation

pyricau
Copy link
Member

@pyricau pyricau commented Nov 25, 2019

  • When adding support for native reference leaks (879ab7c) there was a missing bracket in an if/else branch that led to all native gc roots being ignored.

Fixes #1634

@pyricau
Fix bug in handling JNI roots
2860a3c 
* When adding support for native reference leaks (879ab7c) there was a missing bracket in an if/else branch that led to all native gc roots being ignored.

Fixes #1634
@pyricau pyricau added this to the 2.0 Next Release milestone Nov 25, 2019
@Armaxis
Copy link
Member

Armaxis commented Nov 25, 2019

Filed #1639 to prevent this from happening in the future

@pyricau pyricau merged commit aff3385 into master Nov 25, 2019
@pyricau pyricau deleted the py/dumb_dumb_dumb branch November 25, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Armaxis Armaxis Armaxis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0-beta-5
Development

Successfully merging this pull request may close these issues.

LeakCanary beta 4 fails to find leak that beta 3 does
2 participants
@pyricau @Armaxis