Ref patterns for native global variables #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaks are often caused by native global variables holding references to live objects. On Android this is super common due to the IPC mechanism holding on to instances until the stub in the other process is garbage collected. Fixes #1562
Armaxis
approved these changes
Sep 10, 2019
| SemClipboardManager inner classes are held by native references due to IPC calls | ||
| """.trimIndent() | ||
| references += nativeGlobalVariableLeak( | ||
| "com.samsung.android.content.clipboard.SemClipboardManager$1", description |
There was a problem hiding this comment.
Just confirming it is not a typo that new ref has $1 in the end
UPDATE: nevermind, it is below >_>
|
|
||
| data class NativeGlobalVariablePattern(val className: String) : ReferencePattern() { | ||
| override fun toString(): String { | ||
| return "native global variable referencing $className" |
There was a problem hiding this comment.
Nit: here and in other classes I think it would be better for readability to go with the expression body:
override fun toString() = "native global variable referencing $className"
The strings are short enough to fi within line limit and it will result in nice 3-row data classes
pyricau
added a commit
that referenced
this pull request
Sep 10, 2019
Merged
pyricau
added a commit
that referenced
this pull request
Sep 11, 2019
pyricau
added a commit
that referenced
this pull request
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaks are often caused by native global variables holding references to live objects. On Android this is super common due to the IPC mechanism holding on to instances until the stub in the other process is garbage collected.
Fixes #1562