Report AnimationHandler leak

Fixes #2438
square · Nov 10, 2022 · ffb8bd5 · ffb8bd5
1 parent e306e5c
commit ffb8bd5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/shark-android/api/shark-android.api b/shark-android/api/shark-android.api
@@ -71,6 +71,7 @@ public abstract class shark/AndroidReferenceMatchers : java/lang/Enum {
 	public static final field ACTIVITY_MANAGER_MCONTEXT Lshark/AndroidReferenceMatchers;
 	public static final field ACTIVITY_THREAD__M_NEW_ACTIVITIES Lshark/AndroidReferenceMatchers;
 	public static final field ACTIVITY_TRANSITION_STATE__M_EXITING_TO_VIEW Lshark/AndroidReferenceMatchers;
+	public static final field ANIMATION_HANDLER__ANIMATOR_REQUESTORS Lshark/AndroidReferenceMatchers;
 	public static final field APPLICATION_PACKAGE_MANAGER__HAS_SYSTEM_FEATURE_QUERY Lshark/AndroidReferenceMatchers;
 	public static final field APP_OPS_MANAGER__CALLBACK_STUB Lshark/AndroidReferenceMatchers;
 	public static final field APP_WIDGET_HOST_CALLBACKS Lshark/AndroidReferenceMatchers;

diff --git a/shark-android/src/main/java/shark/AndroidReferenceMatchers.kt b/shark-android/src/main/java/shark/AndroidReferenceMatchers.kt
@@ -866,6 +866,23 @@ enum class AndroidReferenceMatchers {
     }
   },
 
+  ANIMATION_HANDLER__ANIMATOR_REQUESTORS {
+    override fun add(
+      references: MutableList<ReferenceMatcher>
+    ) {
+      references += instanceFieldLeak(
+        "android.animation.AnimationHandler", "mAnimatorRequestors",
+        description = """
+          AnimationHandler is a singleton holding an activity ViewRootImpl requestor after the
+          activity has been destroyed.
+          Report: https://issuetracker.google.com/issues/258534826
+        """.trimIndent()
+      ) {
+        sdkInt == 33
+      }
+    }
+  },
+
   // ######## Manufacturer specific known leaks ########
 
   // SAMSUNG