Merge pull request #2444 from square/py/close_crash_again

Ignore failure to close file
square · Nov 11, 2022 · 2e6488d · 2e6488d
2 parents 7d3fe63 + 5528f4d
commit 2e6488d
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/shark-hprof/src/main/java/shark/ThrowingCancelableFileSourceProvider.kt b/shark-hprof/src/main/java/shark/ThrowingCancelableFileSourceProvider.kt
@@ -1,6 +1,7 @@
 package shark
 
 import java.io.File
+import java.io.IOException
 import okio.Buffer
 import okio.BufferedSource
 import okio.Okio
@@ -40,7 +41,13 @@ class ThrowingCancelableFileSourceProvider(
         return channel.transferTo(position, byteCount, sink)
       }
 
-      override fun close() = channel.close()
+      override fun close() {
+        try {
+          channel.close()
+        } catch (ignored: Throwable) {
+          SharkLog.d(ignored) { "Failed to close file, ignoring" }
+        }
+      }
     }
   }
 }