TypeSpec initializer comment support #967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a more constrained approach to #887. @JakeWharton in reference to #945 (comment), is this approach better suited to merge? Let me know if adjustment are required. |
Scottmitch
force-pushed
the
comment_block
branch
2 times, most recently
from
be3cb0e
to
3724bdc
Compare
Motivation: When generating code it maybe useful to insert comments as anchors for post processing and further extension by other code generation tools. However this is not easy to achieve with the existing API. Modifications: - Add a `TypeSpec.addInitializerComment` method which is emitted only as comments above the `addInitializerBlock`.
Scottmitch
force-pushed
the
comment_block
branch
from
27d49b4
to
42e505a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When generating code it maybe useful to insert
comments as anchors for post processing and further extension by other code generation tools. However
this is not easy to achieve with the existing API.
Modifications:
TypeSpec.addInitializerCommentmethod which is emitted only as comments above theaddInitializerBlock.