Exclude pyrsistent version 0.19.1 from deps #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pyrsistent 0.19.1 had a regression in 0.19.1 which was fixed in 0.19.2 The regression was on pmap where inserted elements were unreliably inserted. See tobgu/pyrsistent#263
namanjain
force-pushed
the
naman/exclude-pyrsistent-version
branch
9 times, most recently
from
4ae8dd1
to
735d2f1
Compare
added 5 commits
November 4, 2022 11:56
Error code for print was changed from T001 to T201 JBKahn/flake8-print#55
namanjain
force-pushed
the
naman/exclude-pyrsistent-version
branch
from
735d2f1
to
8ae96ad
Compare
jqmp
approved these changes
Nov 9, 2022
| @@ -22,7 +22,8 @@ | |||
| "numpy", | |||
| "pandas", | |||
| "pyarrow", | |||
| "pyrsistent", | |||
| "pyrsistent!=0.19.1", | |||
| "decorator<5", | |||
There was a problem hiding this comment.
Could we add a comment explaining the conflict here?
andrewblane
approved these changes
Nov 14, 2022
Yes, I asked in internal slack and 3.6 is not used anymore. Existing pipelines that still are on 3.6 will continue to use the older versions of bionic. |
Yes, I'll open a new PR for bumping version following the release process https://bionic.readthedocs.io/en/stable/maintaining.html?highlight=release#release-process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyrsistent0.19.1 had a regression in 0.19.1 which was fixed in 0.19.2The regression was on pmap where inserted elements were unreliably
inserted. See tobgu/pyrsistent#263