This repository has been archived by the owner on Nov 2, 2023. It is now read-only.
sdk/middleware/sqgin: fix request ctx #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julio-Guerra
force-pushed
the
fix-sqgin-request-ctx
branch
2 times, most recently
from
84ce914
to
1039bca
Compare
|
Thanks a lot Amnay. |
|
On a side note, I created this related issue gin-gonic/gin#2516 as this problem wouldn't happen if the request and gin contexts would be correctly "merged" together. |
Gin's context wrongly implements `context.Context` and doesn't wrap the underlying request context at all. Therefore, we need to use the actual request context `c.Request.Context()` so that the agent can properly manage the request context, but also to correctly propagate values stored in the context.
Julio-Guerra
force-pushed
the
fix-sqgin-request-ctx
branch
from
1039bca
to
a555f99
Compare
Merged
Julio-Guerra
added a commit
that referenced
this pull request
Sep 30, 2020
Fixes: - (#158) PII: make the PII scrubbing of In-App WAF attack events case-insensitive in order to correctly scrub transformed request parameters. - (#159) Monitoring: fix the content type and length monitoring of HTTP responses. - (#157) Gin middleware: use the request Go context instead of Gin's so that the agent can properly manage the request execution context, but also to correctly propagate values stored in the Go context before the middleware function.
Julio-Guerra
added a commit
that referenced
this pull request
Sep 30, 2020
Fixes - (#158) PII: make the PII scrubbing of In-App WAF attack events case-insensitive in order to correctly scrub transformed request parameters. - (#159) Monitoring: fix the content type and length monitoring of HTTP responses. - (#157) Gin middleware: use the request Go context instead of Gin's so that the agent can properly manage the request execution context, but also to correctly propagate values stored in the Go context before the middleware function.
Julio-Guerra
added a commit
that referenced
this pull request
Oct 1, 2020
Fixes: - (#158) PII: make the PII scrubbing of In-App WAF attack events case-insensitive in order to correctly scrub transformed request parameters. - (#159) Monitoring: fix the content type and length monitoring of HTTP responses. - (#157) Gin middleware: use the request Go context instead of Gin's so that the agent can properly manage the request execution context, but also to correctly propagate values stored in the Go context before the middleware function.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where gin's
c.Request's context gets overwritten by thesqginmiddlewareIf you set some values in the context of
c.Request, you won't be able to retrieve them aftersqgin's 'middlewareHandler' has done its work